Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests pass until 2037 #7512

Closed
wants to merge 1 commit into from
Closed

Make tests pass until 2037 #7512

wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link
Contributor

after 2038 something in (or behind) test1915 fails on 32-bit OSes.
It will need fixing within the next years.

@bmwiedemann
Make tests pass until 2037
de92149 
after 2038 something in test1915 fails on 32-bit OSes
bagder
bagder approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extending life of these tests by seven years. OK!

@bagder bagder closed this in 8d0c113 Jul 30, 2021
@bagder
Copy link
Member

bagder commented Jul 30, 2021

Thanks!

@bmwiedemann
Copy link
Contributor Author

Still would be good to find out why test1915 fails with a 2038 date on 32-bit OSes - I think other tests passed.

@bagder
Copy link
Member

bagder commented Jul 30, 2021

I think you mean 32 bit time_t right? Some 32 bit OSes now have 64 bit time_ts and before 2038 we might see even more...

This might explain it:

curl/lib/parsedate.c

Lines 488 to 491 in 8d0c113

if(yearnum > 2037) {
*output = TIME_T_MAX;
return PARSEDATE_LATER;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmwiedemann @bagder