Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: tweak nghttp2 library name fix again #7485

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Jul 24, 2021

  • Change extraction to handle multiple library names returned by
    pkg-config (eg a possible scenario with pkg-config --static).

Ref: #7472

Closes #xxxx

- Change extraction to handle multiple library names returned by
  pkg-config (eg a possible scenario with pkg-config --static).

Ref: curl#7472

Closes #xxxx
@jay jay added the build label Jul 24, 2021
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes against the previous change a little, as that would adapt to whatever custom name the nghttp2 library has been given, while this change now requires the new name to contain 'nghttp2' at least. But if we don't want to revert the entire support for custom library names, I think this is the best approach.

@jay jay closed this in b4b34db Jul 25, 2021
@jay jay deleted the fix_build_nghttp2_static branch July 25, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants