docs: make the documentation for --etag-save match the program behaviour
#7429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxz
changed the title
--etag-save match the program behaviour.--etag-save match the program behaviour.
maxz
changed the title
--etag-save match the program behaviour.--etag-save match the behaviour
maxz
changed the title
--etag-save match the behaviour--etag-save match the program behaviour
When using curl with the option `--etag-save` I expected it to save the ETag without its surrounding quotes, as stated by the documentation in the repository and by the generated man pages. My first endeavour was to fix the program, but while investigating the history of the relevant parts, I discovered that curl once saved the ETag without the quotes. This was undone by Daniel Stenberg in commit `98c94596f5928840177b6bd3c7b0f0dd03a431af`, therefore I decided that in this case the documentation should be adjusted to match the behaviour of curl. The changed save behaviour also made parts of the `--etag-compare` documentation wrong or superfluous, so I adjusted those accordingly.
bagder
approved these changes
Jul 18, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using curl with the option
--etag-saveI expected it to save the ETag without its surrounding quotes, as stated by the documentation in the repository and by the generated man pages.My first endeavour was to fix the program, but while investigating the history of the relevant parts, I discovered that curl once saved the ETag without the quotes.
This was undone by Daniel Stenberg (@bagder) in commit
98c94596f5928840177b6bd3c7b0f0dd03a431af, therefore I decided that in this case the documentation should be adjusted to match the behaviour of curl.The changed save behaviour also made parts of the
--etag-comparedocumentation wrong or superfluous, so I adjusted those accordingly.