cleanup: spell DoH with a lowercase o #7413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
jsoref
commented
Jul 16, 2021
| @@ -65,7 +65,7 @@ the correct end-point. | |||
| .SH DEFAULT | |||
| 1 | |||
| .SH PROTOCOLS | |||
| DOH | |||
| DoH | |||
There was a problem hiding this comment.
Less certain about this
|
|
||
| Note that if this option is enabled but the server does not support the TLS | ||
| extension, the verification will fail. | ||
| .SH DEFAULT | ||
| 0 | ||
| .SH PROTOCOLS | ||
| DOH | ||
| DoH |
Comment on lines
+196
to
+198
| infof(data, "a DoH request is completed, %u to go", dohp->pending); | ||
| if(result) | ||
| infof(data, "DOH request %s", curl_easy_strerror(result)); | ||
| infof(data, "DoH request %s", curl_easy_strerror(result)); |
There was a problem hiding this comment.
this pair changes output
| @@ -768,7 +768,7 @@ static void showdoh(struct Curl_easy *data, | |||
| for(i = 0; i < d->numaddr; i++) { | |||
| const struct dohaddr *a = &d->addr[i]; | |||
| if(a->type == DNS_TYPE_A) { | |||
| infof(data, "DOH A: %u.%u.%u.%u", | |||
| infof(data, "DoH A: %u.%u.%u.%u", | |||
| @@ -777,7 +777,7 @@ static void showdoh(struct Curl_easy *data, | |||
| char buffer[128]; | |||
| char *ptr; | |||
| size_t len; | |||
| msnprintf(buffer, 128, "DOH AAAA: "); | |||
| msnprintf(buffer, 128, "DoH AAAA: "); | |||
| @@ -958,7 +958,7 @@ CURLcode Curl_doh_is_resolved(struct Curl_easy *data, | |||
| &de); | |||
| Curl_dyn_free(&p->serverdoh); | |||
| if(rc[slot]) { | |||
| infof(data, "DOH: %s type %s for %s", doh_strerror(rc[slot]), | |||
| infof(data, "DoH: %s type %s for %s", doh_strerror(rc[slot]), | |||
| @@ -969,7 +969,7 @@ CURLcode Curl_doh_is_resolved(struct Curl_easy *data, | |||
| struct Curl_dns_entry *dns; | |||
| struct Curl_addrinfo *ai; | |||
|
|
|||
| infof(data, "DOH Host name: %s", dohp->host); | |||
| infof(data, "DoH Host name: %s", dohp->host); | |||
bagder
approved these changes
Jul 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/DNS_over_HTTPS
curl/lib/doh.h
Line 31 in 3085ccf
I'm not entirely certain about the full set of changes, as some might change the behavior of clients that are parsing output. Happy to drop any sets.