Make Curl_gss_log_error more verbose #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispaly also the GSS_C_GSS_CODE (major code) when specified, instead of only GSS_C_MECH_CODE (minor code). In addition, the old code was printing twice a colon after the prefix and also miscalculated the length of the buffer in between calls to gss_display_status (the length of ": " was missing). Also, gss_buffer is not guaranteed to be NULL terminated and need to restrict reading by its length.
|
By analyzing the blame information on this pull request, we identified @captain-caveman2k, @jchaffraix and @bagder to be potential reviewers |
|
Thanks, I fixed a mistake in a comment and a minor indentation error. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispaly also the GSS_C_GSS_CODE (major code) when specified,
instead of only GSS_C_MECH_CODE (minor code).
In addition, the old code was printing twice a colon after the
prefix and also miscalculated the length of the buffer in between
calls to gss_display_status (the length of ": " was missing).
Also, gss_buffer is not guaranteed to be NULL terminated and
need to restrict reading by its length.
Discussed over #723