build: fix IoctlSocket FIONBIO check
#7375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like it checks by calling IoctlSocket with a socket of 0 in FIONBIO so it does check something... beats me if it actually works or not. Anyone that can target amiga want to check? |
bagder
approved these changes
Jul 16, 2021
|
Me neither :/ |
|
Looks right enough. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAVE_IOCTLSOCKET_CAMEL_FIONBIOshould get defined ifIoctlSocketwithFIONBIOis available, but the current check uses the (lowercase)ioctlsocketfunction, resulting in the same check that is done forHAVE_IOCTLSOCKET_FIONBIO.But... Does this make sense? This doesn't really check that
ioctlsocketsupports theFIONBIOmode, but it just makes sure that the code compiles; so in reality this just checks ifFIONBIOis defined, since theioctlsocketcheck is already made when settingHAVE_IOCTLSOCKET. But maybe I'm missing something, I'm not really familiar with the Win32 API (or Amiga, since this seems the only system that has a camelcaseIoctlSocketfunction).