Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infof: remove newline from format strings, always append it #7357

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jul 7, 2021

  • the data needs to be "line-based" anyway since it's also passed to the debug callback/application
  • it makes infof() work like failf() and consistency is good
  • there's an assert that triggers on newlines in the format string
  • Also removes a few instances of "..."
  • Removes the code that would append "..." to the end of the data iff it was truncated in infof()

@jay jay added the tidy-up label Jul 7, 2021
bagder added a commit that referenced this pull request Jul 7, 2021
- the data needs to be "line-based" anyway since it's also passed to the
  debug callback/application

- it makes infof() work like failf() and consistency is good

- there's an assert that triggers on newlines in the format string

- Also removes a few instances of "..."

- Removes the code that would append "..." to the end of the data *iff*
  it was truncated in infof()

Closes #7357
- the data needs to be "line-based" anyway since it's also passed to the
  debug callback/application

- it makes infof() work like failf() and consistency is good

- there's an assert that triggers on newlines in the format string

- Also removes a few instances of "..."

- Removes the code that would append "..." to the end of the data *iff*
  it was truncated in infof()

Closes #7357
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read every line of this large diff, but I'm 👍 on the concept and the changes to ´Curl_infof` look sane.

@bagder bagder closed this in e7416cf Jul 7, 2021
@bagder bagder deleted the bagder/infof-cleanup branch July 30, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants