Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scan-build warnings #7248

Closed
wants to merge 3 commits into from
Closed

fix scan-build warnings #7248

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 12, 2021

No description provided.

@bagder
url.c: remove two variable assigns that are never read
9dfb737 
Pointed out by scan-build
@bagder
asyn-ares: remove check for 'data' in Curl_resolver_cancel
573d1b7 
It implied it would survive a NULL in there which it won't. Instead do
an assert.

Pointed out by scan-build.
@bagder bagder added the tidy-up label Jun 12, 2021
@bagder bagder mentioned this pull request Jun 12, 2021
Closed
@bagder
multi: add scan-build-6 work-around in curl_multi_fdset
4ad16a5 
scan-build-6 otherwise warns, saying: warning: The left operand of '>='
is a garbage value otherwise, which is false.

Later scan-builds don't claim this on the same code.
@bagder bagder changed the title fix two scan-build warnings fix scan-build warnings Jun 12, 2021
@bagder bagder closed this in 73f52ad Jun 13, 2021
bagder added a commit that referenced this pull request Jun 13, 2021
@bagder
asyn-ares: remove check for 'data' in Curl_resolver_cancel
c4b8ec4 
It implied it would survive a NULL in there which it won't. Instead do
an assert.

Pointed out by scan-build.

Closes #7248
bagder added a commit that referenced this pull request Jun 13, 2021
@bagder
multi: add scan-build-6 work-around in curl_multi_fdset
77bc359 
scan-build-6 otherwise warns, saying: warning: The left operand of '>='
is a garbage value otherwise, which is false.

Later scan-builds don't claim this on the same code.

Closes #7248
@bagder bagder deleted the bagder/scan-build-warns branch June 13, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder