MQTT file size improvements #7166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piru
commented
Jun 1, 2021
piru
commented
- detect when reported file size is obviously illegal as per MQTT Version 5.0 section "1.5.5 Variable Byte Integer"
- return CURLE_FILESIZE_EXCEEDED when file size would exceed limit set by CURLOPT_MAXFILESIZE_LARGE (if set)
… CURLOPT_MAXFILESIZE_LARGE
bagder
approved these changes
Jun 1, 2021
|
I think the file size check should come a bit later, I'll adjust the code a bit. I'll also look into implementing test for the bogus size being returned by the server. |
added 2 commits
June 2, 2021 01:13
…llegal size sent by the server and client --max-filesize working as expected
…en in some circumstances it seems
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.