Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl_ssl_getsessionid: survive a missing session id cache #7153

Closed
wants to merge 2 commits into from
Closed

Curl_ssl_getsessionid: survive a missing session id cache #7153

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 31, 2021

(Regression probably introduced in 7f4a9a9)

Fixes #7148

@bagder
Curl_ssl_getsessionid: fail if no session cache exists
0daeb68 
This function might get called for an easy handle for which the session
cache hasn't been setup. It now just returns a "miss" in that case.

Fixes #7148
@bagder
http2: init recvbuf struct for pushed streams
0a8f781 
Debug builds would warn that these structs were not initialized properly
for pushed streams.

Ref: #7148
@bagder bagder added the TLS label May 31, 2021
@cmb69
Copy link
Contributor

cmb69 commented May 31, 2021

I can confirm that this fixes the issue. Thanks for the swift response! :)

@bagder bagder closed this in 894c747 May 31, 2021
bagder added a commit that referenced this pull request May 31, 2021
@bagder
http2: init recvbuf struct for pushed streams
ef1a917 
Debug builds would warn that these structs were not initialized properly
for pushed streams.

Ref: #7148
Closes #7153
@bagder bagder deleted the bagder/fix-7148 branch May 31, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

curl 7.77.0 regression: segfault in Curl_ssl_getsessionid()
2 participants
@bagder @cmb69