Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperstream: couldn't get response when using hyper #7122

Closed
kevinburke1 opened this issue May 24, 2021 · 1 comment
Closed

hyperstream: couldn't get response when using hyper #7122

kevinburke1 opened this issue May 24, 2021 · 1 comment
Labels
Hyper regression

Comments

@kevinburke1
Copy link

kevinburke1 commented May 24, 2021 •
edited

Commit c3eefa9 contains a fix for #7064. Unfortunately, when I try to compile curl with rustls+hyper using this patch, I get:

curl: (56) hyperstream: couldn't get response

And then no response output where I would expect to see it.

on a variety of HTTP responses, HTTP/1.1, TLS with HTTP/2. I can reproduce using either http://public.meter.com or https://public.meter.com (both of which are Amazon ALB's), for example.

On other sites, for example https://jsonip.com, I see curl: (56) hyperstream: couldn't get response but then the response also prints out.

If I revert the commit mentioned there, I don't see the issue appearing anymore, and I also can't reproduce the 1 second sleep I was occasionally seeing (perhaps something changed in crustls or Hyper?)

Here are more logs from success and failure cases. https://gist.github.com/kevinburkemeter/c7fd42f5da7b78e2683179d874f0a475
@kevinburke1 kevinburke1 mentioned this issue May 24, 2021
Closed
@bagder
Copy link
Member

bagder commented May 26, 2021

I think we should start with reverting this. I can't even run test case 1 if I don't revert c3eefa9 ...

I'll make a PR

bagder added a commit that referenced this issue May 26, 2021
@bagder
Revert "c-hyper: handle body on HYPER_TASK_EMPTY"
343696f 
This reverts commit c3eefa9.

Reported-by: Kevin Burke
Fixes #7122
@bagder bagder mentioned this issue May 26, 2021
Closed
bagder added a commit that referenced this issue May 26, 2021
@bagder
Revert "c-hyper: handle body on HYPER_TASK_EMPTY"
0c89784 
This reverts commit c3eefa9.

Reported-by: Kevin Burke
Fixes #7122
@bagder bagder closed this as completed in 2ee761c May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hyper regression
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "c-hyper: handle body on HYPER_TASK_EMPTY" curl/curl
2 participants
@bagder @kevinburke1