Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: add CURL_ENABLE_EXPORT_TARGET option. #7060

Closed
wants to merge 1 commit into from
Closed

CMake: add CURL_ENABLE_EXPORT_TARGET option. #7060

wants to merge 1 commit into from

Conversation

lemourin
Copy link
Contributor

install(EXPORT ...) causes trouble when embedding curl dependencies which
don't provide install(EXPORT ...) targets (e.g libressl and nghttp2) with
cmake's add_subdirectory.

@lemourin
CMake: add CURL_ENABLE_EXPORT_TARGET option.
9f4be8c 
install(EXPORT ...) causes trouble when embedding curl dependencies which
don't provide install(EXPORT ...) targets (e.g libressl and nghttp2) with
cmake's add_subdirectory.
@bagder bagder added the cmake label May 14, 2021
@bagder bagder requested a review from jzakrzewski May 24, 2021 14:44
jzakrzewski
jzakrzewski approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jzakrzewski jzakrzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in adding this.

@bagder
Copy link
Member

bagder commented May 25, 2021

Thanks!

@bagder bagder closed this in 643ec29 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzakrzewski jzakrzewski jzakrzewski approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemourin @bagder @jzakrzewski