Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake doesn't figure out CURL_SA_FAMILY_T - build causes warnings #7049

Closed
bagder opened this issue May 11, 2021 · 0 comments
Closed

cmake doesn't figure out CURL_SA_FAMILY_T - build causes warnings #7049

bagder opened this issue May 11, 2021 · 0 comments
Labels
cmake help wanted KNOWN_BUGS material

Comments

@bagder
Copy link
Member

bagder commented May 11, 2021

I did this

built curl with cmake on macOS

It cases warnings like:

/Users/runner/work/curl/curl/lib/curl_addrinfo.c:329:26: warning: conversion from 'short unsigned int' to 'sa_family_t' {aka 'unsigned char'} may change value [-Wconversion]
  329 |       addr->sin_family = (CURL_SA_FAMILY_T)(he->h_addrtype);
      |                          ^
/Users/runner/work/curl/curl/lib/curl_addrinfo.c:338:28: warning: conversion from 'short unsigned int' to 'sa_family_t' {aka 'unsigned char'} may change value [-Wconversion]
  338 |       addr6->sin6_family = (CURL_SA_FAMILY_T)(he->h_addrtype);
      |                            ^

... because the cmake build doesn't detect CURL_SA_FAMILY_T properly. configure does.

I expected the following

No warnings

curl/libcurl version

curl 7.76.1 and current curl git master

operating system

macOS but probably also elsewhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake help wanted KNOWN_BUGS material
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config/cmake: configure CURL_SA_FAMILY_T properly for macOS starrify/curl
1 participant
@bagder