Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes to avoid sockfilt getting stuck on Windows #6992

Closed
wants to merge 2 commits into from
Closed

Multiple fixes to avoid sockfilt getting stuck on Windows #6992

wants to merge 2 commits into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented May 2, 2021

  • avoid getting stuck waiting for writable socket
  • fix invalid increment of handles index variable nfd

@mback2k
sockfilt: avoid getting stuck waiting for writable socket
a3b19f3 
Reset FD_WRITE event using the same approach as in multi.c

Follow up to b36442b
@mback2k
sockfilt: fix invalid increment of handles index variable nfd
607a625 
Only increment the array index if we actually stored a handle.

Follow up to e917492
@mback2k mback2k added the tests label May 2, 2021
@mback2k mback2k self-assigned this May 2, 2021
@mback2k mback2k marked this pull request as ready for review May 5, 2021 20:23
@mback2k mback2k closed this in b9239e0 May 5, 2021
mback2k added a commit that referenced this pull request May 5, 2021
@mback2k
sockfilt: fix invalid increment of handles index variable nfd
d698c70 
Only increment the array index if we actually stored a handle.

Follow up to e917492
Closes #6992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mback2k mback2k

Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mback2k