Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ALPN in rustls #6960

Closed
wants to merge 2 commits into from
Closed

Use ALPN in rustls #6960

wants to merge 2 commits into from

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Apr 25, 2021 •
edited

No description provided.

@jsha jsha marked this pull request as draft April 25, 2021 02:02
kevinburke1
kevinburke1 reviewed Apr 29, 2021
View reviewed changes
lib/vtls/rustls.c Outdated Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented Apr 29, 2021

The travis build is unhappy:

vtls/rustls.c: In function ‘cr_init_backend’:
vtls/rustls.c:337:3: error: implicit declaration of function ‘rustls_client_config_builder_set_protocols’; did you mean ‘rustls_server_config_builder_set_protocols’? [-Wimplicit-function-declaration]
   rustls_client_config_builder_set_protocols(config_builder, alpn, 2);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   rustls_server_config_builder_set_protocols
vtls/rustls.c:337:3: error: nested extern declaration of ‘rustls_client_config_builder_set_protocols’ [-Werror=nested-externs]
vtls/rustls.c: In function ‘cr_set_negotiated_alpn’:
vtls/rustls.c:393:3: error: implicit declaration of function ‘rustls_client_session_get_alpn_protocol’; did you mean ‘rustls_client_session_read_tls’? [-Wimplicit-function-declaration]
   rustls_client_session_get_alpn_protocol(session, &protocol, &len);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   rustls_client_session_read_tls
vtls/rustls.c:393:3: error: nested extern declaration of ‘rustls_client_session_get_alpn_protocol’ [-Werror=nested-externs]
cc1: all warnings being treated as errors

@bagder
Copy link
Member

bagder commented Apr 29, 2021

Ah, I guess that is because of the waiting PRs mentioned here already...

@jsha
Copy link
Contributor Author

jsha commented Apr 30, 2021

Oops, sorry about that. The crustls PR was merged, but I needed to tag a new release (0.5.0). I've done that now and updated .travis.yml and docs/RUSTLS.md to match.

@jsha jsha marked this pull request as ready for review April 30, 2021 00:26
@bagder bagder closed this in 8228002 Apr 30, 2021
@bagder
Copy link
Member

bagder commented Apr 30, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinburke1 kevinburke1 kevinburke1 left review comments

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
HTTP/2 TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsha @bagder @kevinburke1