Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustls compilation should include CoreFoundation and Security frameworks on Mac #6955

Closed
kevinburke opened this issue Apr 24, 2021 · 2 comments
Closed

Rustls compilation should include CoreFoundation and Security frameworks on Mac #6955

kevinburke opened this issue Apr 24, 2021 · 2 comments
Labels
build TLS

Comments

@kevinburke
Copy link
Contributor

Without these frameworks compiled in, the --with-rustls flag on Macs fails with a bunch of errors related to missing symbols that are present in the CoreFoundation or Security frameworks.

People may not notice this because compilation does not error if you include the --with-secure-transport flag - that one appends the correct CoreFoundation framework flags to LDFLAGS. Unfortunately including that flag means that curl chooses SecureTransport for TLS and not rustls, so as is, it's essentially impossible to use rustls for TLS on Mac.
kevinburke added a commit to kevinburke/curl that referenced this issue Apr 24, 2021
@kevinburke
m4: add security frameworks on Mac when compiling rustls
617d5ff 
Previously compiling rustls on Mac would only complete if you also
compiled the SecureTransport TLS backend, which curl would prefer to
the Rust backend.

Appending these flags to LDFLAGS makes it possible to compile the
Rustls backend on Mac without the SecureTransport backend, which means
this patch will make it possible for Mac users to use the Rustls
backend for TLS.

Fixes curl#6955.
@kevinburke kevinburke mentioned this issue Apr 24, 2021
Closed
@bagder
Copy link
Member

bagder commented Apr 25, 2021

@jsha, thoughts?

@jsha
Copy link
Contributor

jsha commented Apr 25, 2021

I think this is correct, and sent an approval on the corresponding PR (#6956)

@bagder bagder closed this as completed in 9f71cc2 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build TLS
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

m4: add security frameworks on Mac when compiling rustls kevinburke/curl
3 participants
@bagder @jsha @kevinburke