New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant check in cookie_output() #695

Closed

Dmitry-Me opened this issue Mar 2, 2016 · 0 comments

Dmitry-Me commented Mar 2, 2016

cookie.c contains cookie_output() which caused a false positive in Cppcheck. Code goes like this:

  if((NULL == c) || (0 == c->numcookies))
    return 0;
  remove_expired(c);
 /* WHATEVER, doesn't change c */

  if(c) { /* WHATEVER */

The if(c) is redundant - if c is NULL then control never gets to the if.

The text was updated successfully, but these errors were encountered:

bagder closed this as completed in

33a0a92

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.