Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid static for sock_opt in nss_set_blocking #6945

Closed
wants to merge 1 commit into from
Closed

avoid static for sock_opt in nss_set_blocking #6945

wants to merge 1 commit into from

Conversation

piru
Copy link

@piru piru commented Apr 23, 2021

using static data can lead to confusion of the blocking status between simultaneous calls

@bagder
Copy link
Member

bagder commented Apr 23, 2021

The 2c6a728 commit seems unrelated though, right?

@piru
Copy link
Author

piru commented Apr 23, 2021

The 2c6a728 commit seems unrelated though, right?

Oh yeah. At times I hate my inability with git...

@bagder bagder linked an issue Apr 25, 2021 that may be closed by this pull request
nss_set_blocking static sock_opt variable leading to incorrect blocking status #6944
Closed
@bagder bagder requested a review from kdudka April 25, 2021 12:47
kdudka
kdudka approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This problem was introduced in commit 8fa5409 which made the flag parameterized. The fix looks appropriate. Thanks!

bagder
bagder approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is still marked "draft" @piru ?

@piru piru marked this pull request as ready for review April 26, 2021 06:14
@bagder bagder closed this in f2e1163 Apr 26, 2021
@bagder
Copy link
Member

bagder commented Apr 26, 2021

Thanks!

@bagder bagder mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@kdudka kdudka kdudka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nss_set_blocking static sock_opt variable leading to incorrect blocking status
3 participants
@piru @bagder @kdudka