Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented gsasl version info in curl_version_info struct #6843

Closed

Conversation

MortenMacFly
Copy link

As a follow-up to the discussion on the libcurl mailing list I've implemented the ability to obtain the gsasl version info from the curl_version_info struct as it is done with the other third party libs, too.
Rationale: Ability to structure and format version info e.g. on a GUI an not relay on the long, unformatted string from curl_version() method.

@bagder
Copy link
Member

bagder commented Apr 4, 2021

Thanks!

The new symbol needs to be added to docs/libcurl/symbols-in-versions to make test 1119 pass!

@MortenMacFly
Copy link
Author

Thanks!
The new symbol needs to be added to docs/libcurl/symbols-in-versions to make test 1119 pass!

Ah, OK - I understand. The question is: What version should I add? The reference version (7.76.0) or the upcoming - which is either 7.76.1 or 7.77.0?

Sorry for maybe asking stupid questions, I am new to this. :-)

@bagder
Copy link
Member

bagder commented Apr 4, 2021

We'll count this as a change, so it will not be merged for 7.76.1. We should plan to get it into 7.77.0

@bagder bagder added the feature-window A merge of this requires an open feature window label Apr 4, 2021
@jay jay removed the feature-window A merge of this requires an open feature window label Apr 22, 2021
@jay jay closed this in e540b32 Apr 22, 2021
@jay
Copy link
Member

jay commented Apr 22, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants