Skip to content

Compile failure in hostip.c without USE_CURL_ASYNC #6831

New issue
New issue
Closed
Closed
Compile failure in hostip.c without USE_CURL_ASYNC#6831
Labels
buildname lookupDNS and related tech
@bnason-nf

Description

@bnason-nf
bnason-nf
opened on Apr 1, 2021

Hi,

When building the latest curl (7.76.0) without asynchronous name resolution (USE_CURL_ASYNC is undefined), hostip.c fails to compile because the failf() call references the async member which doesn't exist. Probably this whole function can be omitted in this scenario.

Thanks,
Benbuck

Activity

jay
added
build
name lookupDNS and related tech
on Apr 1, 2021
jay
mentioned this on Apr 1, 2021
jay

jay commented on Apr 1, 2021

@jay
jay
on Apr 1, 2021
Member

I can reproduce this but only if the DNS backend is synchronous and DOH is disabled. See #6832

bnason-nf

bnason-nf commented on Apr 1, 2021

@bnason-nf
bnason-nf
on Apr 1, 2021
ContributorAuthor

Hi @jay,

I appreciate the quick response, and yes, our configuration is probably pretty unusual. I think maybe it would be good to add the same ifdef to Curl_resolver_error() in hostip.h for consistency?

Thanks,
Benbuck

jay
closed this as completedin 3085ccfon Apr 2, 2021
jay

jay commented on Apr 2, 2021

@jay
jay
on Apr 2, 2021
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildname lookupDNS and related tech

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jay@bnason-nf

      Issue actions
        Compile failure in hostip.c without USE_CURL_ASYNC · Issue #6831 · curl/curl