New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libssh: get rid of PATH_MAX #6829
Conversation
This removes the last occurrence of PATH_MAX inside our libssh implementation by calculating the path length from the string length of the two components. Closes curl#6829
67b700e
to
9a07794
Compare
This removes the last occurrence of PATH_MAX inside our libssh implementation by calculating the path length from the string length of the two components. Closes curl#6829
9a07794
to
bfff6dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try switching to aprintf() instead of malloc + snprintf ? That can avoid having strlens and strings in two places risk at some point deviate when code changes over time.
Not yet, I will have a deeper look at it this evening. So far I only focused on getting rid of PATH_MAX due to various reasons |
This removes the last occurrence of PATH_MAX inside our libssh implementation by calculating the path length from the string length of the two components. Closes curl#6829
bfff6dc
to
e5e5b3c
Compare
Hey, sorry that Friday evening evolved into Sunday noon. I adjusted the patch to use aprintf(). I think this is ready to be merged. |
Thanks |
This removes the last occurrence of PATH_MAX inside our libssh
implementation by calculating the path length from the string length of
the two components.