Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: ensure to check SSL_CTX_set_alpn_protos return values #6794

Closed
wants to merge 2 commits into from
Closed

openssl: ensure to check SSL_CTX_set_alpn_protos return values #6794

wants to merge 2 commits into from

Conversation

jpmenil
Copy link
Contributor

@jpmenil jpmenil commented Mar 25, 2021

SSL_CTX_set_alpn_protos() return 0 on success, and non-0 on failure

Signed-off-by: Jean-Philippe Menil jpmenil@gmail.com

@jpmenil
openssl: ensure to check SSL_CTX_set_alpn_protos return values
b75eda6 
SSL_CTX_set_alpn_protos() return 0 on success, and non-0 on failure

Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
bagder
bagder reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeps, I think we should check the return code!

lib/vtls/openssl.c Outdated Show resolved Hide resolved
@bagder bagder added the TLS label Mar 25, 2021
@jpmenil
remove code comparison, to match code convention
ae1eace 
Signed-off-by: Jean-Philippe Menil <jpmenil@gmail.com>
@bagder
Copy link
Member

bagder commented Mar 25, 2021

Thanks!

@bagder bagder closed this in 5930cb1 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpmenil @bagder