New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookies: Support multiple -b parameters #6649
Conversation
Previously only a single -b cookie parameter was supported with the last one winning. This adds support for supplying multiple -b params to have them serialized semicolon separated. Both cookiefiles and cookies can be entered multiple times. Closes #xxxx
Question is, do we want |
I think it makes sense and it probably makes the option easier to document/use... |
5124e41
to
4bb4049
Compare
Pushed a rebase with support for multiple cookiefiles and some test updates. |
The single buildfailure in Appveyor is test 1509 which isn't related to cookies at all, likely a flake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be worth adding something to docs/cmdline/cookie.d
too about this, but other than that I think this looks fine!
On 25 Feb 2021, at 16:15, Daniel Stenberg ***@***.***> wrote:
@bagder approved this pull request.
I think it could be worth adding something to docs/cmdline/cookie.d too about this, but other than that I think this looks fine!
Good point, I'll add a small note there before pushing to master.
|
It currently says "If this option is used several times, the last one will be used." |
Previously only a single -b cookie parameter was supported with the last one winning. This adds support for supplying multiple -b params to have them serialized semicolon separated.
This is bit of a draft PR so far which lacks tests.