Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mingw: enable using strcasecmp() #6644

Closed
wants to merge 1 commit into from
Closed

mingw: enable using strcasecmp() #6644

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Feb 22, 2021 •
edited

This will make the Features: list sorted case-insensitively, bringing output in-line with *nix builds.

@vszakats vszakats added the Windows Windows-specific label Feb 22, 2021
@jay
Copy link
Member

jay commented Feb 23, 2021

You could get rid of HAVE_STRCASECMP as well and replace strcasecmp with curl_strequal

@bagder
Copy link
Member

bagder commented Feb 23, 2021

The only current use of strcasecmp() is src/tool_help.c which uses the function as input to qsort(). This means curl_strequal() is not a simple drop-in replacement as they differ in return codes, in particular when there's not a match.

@jay
Copy link
Member

jay commented Feb 23, 2021

This means curl_strequal() is not a simple drop-in replacement as they differ in return codes, in particular when there's not a match.

ah didn't realize that.. disregard then

@vszakats vszakats closed this in fb98a43 Feb 23, 2021
@vszakats vszakats deleted the mingw-strcasecmp branch February 23, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay approved these changes

Assignees
No one assigned
Labels
Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vszakats @jay @bagder