New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hyper opt-in, and fail when missing #6598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this isn't sufficient as it seems we run through this condition when the option isn't even specified so this change causes build failures. example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaks the build
I had assumed the ./configure behavior was not to try hyper unless Rationale: I was trying to build with Hyper yesterday, and was having trouble getting it configured correctly. I needed to make sure to build with the right feature flags and the right RUSTFLAGS, and put it in the right place, and set up LD_LIBRARY_PATH and CFLAGS=-L/usr/local/lib. That's all fine: part of the software life. But my debugging cycles were longer than necessary, because if my Hyper install was broken, |
I think it was a mistake. I think we should require the |
Previously, configure would look for hyper by default, and use it if found; otherwise it would not use hyper, and not error. Now, configure will not look for hyper unless --with-hyper is passed. If configure looks for hyper and fails, it will error. Also, add -ld -lpthread -lm to Hyper's libs. I think they are required.
bd43f30
to
067fddb
Compare
Updated the change (including PR title and description) based on the conversation above. |
Thanks! |
Previously, configure would look for hyper by default, and use it if
found; otherwise it would not use hyper, and not error.
Now, configure will not look for hyper unless --with-hyper is passed. If
configure looks for hyper and fails, it will error.
Also, add -ld -lpthread -lm to Hyper's libs. I think they are required.