Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Use CMAKE_INSTALL_INCLUDEDIR indirection #6440

Closed
wants to merge 1 commit into from
Closed

cmake: Use CMAKE_INSTALL_INCLUDEDIR indirection #6440

wants to merge 1 commit into from

Conversation

gjasny
Copy link
Contributor

@gjasny gjasny commented Jan 12, 2021

Like the header installation uses CMAKE_INSTALL_INCLUDEDIR:

curl/CMakeLists.txt

Lines 1516 to 1518 in 3831043

install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/include/curl"
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
FILES_MATCHING PATTERN "*.h")

the exported CMake configuration must use it as well to lookup the installed files in the same place.

@bagder bagder added the cmake label Jan 12, 2021
@bagder bagder requested a review from snikulov February 23, 2021 15:58
snikulov
snikulov approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@snikulov snikulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bagder bagder closed this in 811acd1 Feb 24, 2021
@bagder
Copy link
Member

bagder commented Feb 24, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snikulov snikulov snikulov approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gjasny @bagder @snikulov