Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl CMakeFiles fails to avoid libidn2 detection #6361

Closed
wrowe opened this issue Dec 22, 2020 · 2 comments
Closed

Curl CMakeFiles fails to avoid libidn2 detection #6361

wrowe opened this issue Dec 22, 2020 · 2 comments
Labels
cmake

Comments

@wrowe
Copy link

wrowe commented Dec 22, 2020

envoyproxy/envoy#14506 (comment)

We've identified an issue that it's not possible to escape libidn2 using a conventional CURL_DISABLE_IDN2 toggle. This makes curl unusable in our static release builds at envoy and other projects.
@jay jay added the cmake label Dec 22, 2020
jay added a commit to jay/curl that referenced this issue Dec 22, 2020
@jay
cmake: Add an option to disable libidn2
703337c 
New option USE_LIBIDN2 defaults to ON for libidn2 detection. Prior to
this change libidn2 detection could not be turned off in cmake builds.

Reported-by: William A Rowe Jr

Fixes curl#6361
Closes #xxxx
@jay jay mentioned this issue Dec 22, 2020
Closed
@jay
Copy link
Member

jay commented Dec 22, 2020

Please try #6362

@wrowe
Copy link
Author

wrowe commented Jan 8, 2021

We've introduced 6362 patch into the envoy release 1.17.0 and all appears well. Looking forward to this hitting a curl release soon!

@jay jay closed this as completed in 83f1ca6 Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Add an option to disable libidn2 jay/curl
2 participants
@wrowe @jay