ngtcp2: Fix build error due to symbol name change #6271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- s/NGTCP2_CRYPTO_LEVEL_APP/NGTCP2_CRYPTO_LEVEL_APPLICATION/g ngtcp2/ngtcp2@76232e9 changed the name. Closes #xxxx
Yes. This goes for all our HTTP/3 builds until at least parts of those builds are done with release versions of the involved libraries. Until then, we just keep up with the development versions. |
bagder
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngtcp2/ngtcp2@76232e9 changed the name.
Closes #xxxx
http3 builds in CI broke today due to symbol rename in ngtcp2 so I propose we change the name here too. Unfortunately with this change users that build with old ngtcp2 will then get build errors...