tool_writeout: use _T types instead of doubles #6248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me but the commit message is a bit misleading IMO. The "_T" gives me C++ template flashbacks to some degree. I think "tool_writeout: use custom types instead of standard types" is a better message. |
|
it refers to the curl_easy_getinfo() identifiers. I don't like "custom" vs "standard" as that's not the point. The point is rather that it uses a (large enough) fixed-point type instead of a floating point type. |
Commit 3b80d3c (June 2017) introduced getinfo replacement variables that use curl_off_t instead of doubles. Switch the --write-out function over to use them.
bagder
force-pushed
the
bagder/curl-writeout-t
branch
from
83d7c1b
to
fcfaffe
Compare
bagder
added a commit
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3b80d3c (June 2017) introduced these getinfo
variables that use curl_off_t instead of doubles. Now switch the
--write-out function to use them.