New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: add --create-file-mode [mode] #6244
Conversation
This is a bad idea. The default should be whatever the remote provides, which may be based on directory permissions, ACLs, the server's configuration, the username/authentication credentials used... Directory ACLs can provide a default permission for new files. Server configurations may provide a Forcing 0644 would enforce a policy choice that may not match the remote server's requirements. I support providing a means for the user to request specific permissions - this is a good idea. But the default should not be to override the remote's defaults. The default should be to do nothing - let the remote server do its job. The same analysis applies to establishing file ownership -- absent a specific user request, |
I agree with @tlhackque. I have not reviewed the code yet but as far as I understand the argument can be provided without any subarguments. I would suggest to enforce the input of a mode then? |
This is already what the code does, this PR doesn't introduce this.
No can do. We need to set the exact mode for all these three protocols. Unless you know more than I do. |
I don't understand what you're suggesting here. Can you rephrase or show with an example? |
This option sets the (octal) mode to use for the remote file when one is created, using the SFTP, SCP or FILE protocols. When not set, the default is 0644. Closes #6244
86b0ee8
to
59bf824
Compare
This option sets the (octal) mode to use for the remote file when one is created, using the SFTP, SCP or FILE protocols. When not set, the default is 0644. Closes #6244
59bf824
to
a004d6f
Compare
This option sets the (octal) mode to use for the remote file when one is created, using the SFTP, SCP or FILE protocols. When not set, the default is 0644. Closes #6244
a004d6f
to
3377237
Compare
This option sets the (octal) mode to use for the remote file when one is
created, using the SFTP, SCP or FILE protocols. When not set, the
default is 0644.