Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: append libcurl.rc to source files also for MSYS based system #6215

Closed
wants to merge 1 commit into from
Closed

cmake: append libcurl.rc to source files also for MSYS based system #6215

wants to merge 1 commit into from

Conversation

vtorri
Copy link
Contributor

@vtorri vtorri commented Nov 17, 2020

On MSYS or MSYS2, windres also exists.
Tested with MSYS2 + mingw-w64 toolchain

@bagder bagder added cmake Windows Windows-specific labels Nov 17, 2020
@bagder
Copy link
Member

bagder commented Nov 19, 2020

Seems to work fine in the CI builds. @MarcelRaad @mback2k any objections?

@MarcelRaad
Copy link
Member

No objection, looks reasonable to me.

@bagder bagder closed this in ee38a72 Nov 19, 2020
@bagder
Copy link
Member

bagder commented Nov 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
cmake Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vtorri @bagder @MarcelRaad