Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples recommends deprecated CURLOPT_PUT #6186

Closed
jeroen opened this issue Nov 8, 2020 · 1 comment
Closed

Examples recommends deprecated CURLOPT_PUT #6186

jeroen opened this issue Nov 8, 2020 · 1 comment
Assignees
@bagder
Labels
documentation

Comments

@jeroen
Copy link
Contributor

jeroen commented Nov 8, 2020

Googling how to perform a PUT with libcurl sends you to the httpput.c example which uses CURLOPT_PUT:

curl/docs/examples/httpput.c

Lines 95 to 96 in 374329d

/* HTTP PUT please */
curl_easy_setopt(curl, CURLOPT_PUT, 1L);

But the manual page for this option says "Deprecated, don't use". So maybe the example should be updated?
bagder added a commit that referenced this issue Nov 9, 2020
@bagder
examples/httpput: remove use of CURLOPT_PUT
e8d2e14 
It is deprecated and unnecessary since it already sets CURLOPT_UPLOAD.
Reported-by: Jeroen Ooms
Fixes #6186
@bagder bagder mentioned this issue Nov 9, 2020
Closed
@bagder bagder self-assigned this Nov 9, 2020
@jeroen
Copy link
Contributor Author

jeroen commented Nov 9, 2020 •
edited

As a side-note, it would be useful if the example would also illustrate how to perform a PUT using CURLOPT_POSTFIELDS instead of a file upload. That is what most clients are usually more interested in.

bagder added a commit that referenced this issue Nov 9, 2020
@bagder
httpput-postfields.c: new example doing PUT with POSTFIELDS
123f8c1 
Proposed-by: Jeroen Ooms
Ref: #6186
@bagder bagder mentioned this issue Nov 9, 2020
Closed
@bagder bagder closed this as completed in fa6bbbe Nov 9, 2020
bagder added a commit that referenced this issue Nov 13, 2020
@bagder
httpput-postfields.c: new example doing PUT with POSTFIELDS
71ec4e7 
Proposed-by: Jeroen Ooms
Ref: #6186
Closes #6188
@aartigao aartigao mentioned this issue Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples/httpput: remove use of CURLOPT_PUT curl/curl
2 participants
@bagder @jeroen