tests: Add checksrc exceptions for testcode #6176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autobuilds are reporting checksrc warnings in libtest testcode on struct typedefs and the use of localtime. These are all done intentional to add exceptions to avoid warnings.
bagder
approved these changes
Nov 5, 2020
|
These are actually suppressed in https://github.com/curl/curl/blob/master/tests/libtest/.checksrc, but if I see it correctly that only works for the autobuilds using git, not the ones using the nightly tarball. Does that file maybe have to be added somewhere to appear there? I mean tests/libtest/.checksrc is not contained in https://curl.haxx.se/snapshots/curl-7.74.0-20201105.zip. |
|
Good point, if it's included in when running |
bagder
added a commit
that referenced
this pull request
Dec 21, 2020
... so that (auto)builds from tarballs also get the correct instructions. Fixes #6176
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autobuilds are reporting checksrc warnings in libtest testcode on struct typedefs and the use of localtime. These are all done intentional to add exceptions to avoid warnings.