Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: use ninja-build for CMake builds #6077

Merged
merged 1 commit into from Nov 4, 2020
Merged

travis: use ninja-build for CMake builds #6077

merged 1 commit into from Nov 4, 2020

Conversation

snikulov
Copy link
Member

Added package ninja-build to TravisCI environment
Use ninja to speed up CMake builds

Should speed up build a bit.

@snikulov snikulov added build cmake CI Continuous Integration labels Oct 14, 2020
mback2k
mback2k approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@mback2k mback2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but now we won't be testing CMake generating classic Makefiles for us anymore, right?

@snikulov
Copy link
Member Author

snikulov commented Oct 16, 2020 •
edited

@mback2k yes. I think such tests should be done by CMake guys.
I'm still wondering why BoringSSL been built twice.
But I leave it as it was for Makefiles.
Thought maybe someone will shed some light on this...

@snikulov
travis: use ninja-build for CMake builds
8891805 
Added package ninja-build to environment
Use ninja to speed up CMake builds

Closes curl#6077
@snikulov snikulov merged commit e41ba40 into curl:master Nov 4, 2020
@snikulov
Copy link
Member Author

snikulov commented Nov 4, 2020

merged as e41ba40

@snikulov snikulov deleted the travisci_cmake_use_ninja branch November 4, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@mback2k mback2k mback2k approved these changes

@MarcelRaad MarcelRaad MarcelRaad approved these changes

@jay jay Awaiting requested review from jay

Assignees
No one assigned
Labels
build CI Continuous Integration cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snikulov @bagder @mback2k @MarcelRaad