New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/tests: enable test target on TravisCI for CMake builds #6074
Conversation
19fe6e0
to
4067ed2
Compare
@snikulov can you try also enabling the suppression generation @bagder mentioned here: #6078 (comment), thanks! |
It's done already. |
That's so weird and I don't understand why we get no suppression rules shown. I propose we try adding one manually instead, here's my attempt: diff --git a/tests/valgrind.supp b/tests/valgrind.supp
index 10b07314a..4aaeac5b4 100644
--- a/tests/valgrind.supp
+++ b/tests/valgrind.supp
@@ -1,5 +1,13 @@
+{
+ zstd_decompression-1.3.3
+ Memcheck:cond
+ fun:ZSTD_decompressStream
+ obj:/usr/lib/x86_64-linux-gnu/libzstd.so.1.3.3
+ fun:zstd_unencode_write
+}
+
{
libidn-idna_to_ascii-error
Memcheck:Addr4
fun:idna_to_ascii_4z
fun:idna_to_ascii_8z |
I also tried a configure build on ubuntu 18.04 with libzstd 1.3.3 on a local VM of mine, but I couldn't reproduce the valgrind issues there. 😮 |
Maybe the Windows version of libzstd contains different (#ifdef'ed) code that is causing the issue? |
@mback2k: these valgrind reports happen on the two travis ubuntu 18.04 cmake builds... |
Ah sorry, mixed up the various issues in my head. |
@snikulov try rebasing this now on master and force-push. The valgrind problems should be suppressed now. |
4067ed2
to
2253538
Compare
Test 1139 fails because the cmake build doesn't create Test 1014 looks like a more genuine problem in the cmake build. curl doesn't properly get IDN enabled in the build even though it found libidn2 present. Fixed in #6108 |
... so that curl-config gets correct and makes test 1014 happy! Ref: #6074
This allows the build to enable IDN properly and it makes test 1014 happier. Ref: #6074
2253538
to
ad6b81e
Compare
b296c51
to
9aa1f74
Compare
Added test-nonflaky target to CMake builds Disabled test 1139 because the cmake build doesn't create docs/curl.1
9aa1f74
to
5b9aa59
Compare
Excellent! ❤️ |
Thanks! |
1 similar comment
Thanks! |
Added test-nonflaky target to CMake builds
Ref: #6052