Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unguarded reference to AF_INET6 in lib/connect.c #6069

Closed
tgc opened this issue Oct 13, 2020 · 4 comments
Closed

Unguarded reference to AF_INET6 in lib/connect.c #6069

tgc opened this issue Oct 13, 2020 · 4 comments
Labels
build connecting & proxies

Comments

@tgc
Copy link

tgc commented Oct 13, 2020

There is an unguarded use of AF_INET6 in lib/connect.c:

curl/lib/connect.c

Line 1337 in a326877

conn->tempfamily[1] = conn->tempfamily[0] == AF_INET6 ?

It prevented curl 7.72.0 from building out of the box on Solaris 2.6 as it has no IPv6 support.
After a quick workaround of replacing AF_INET6 with AF_INET the build completed.

Test results after workaround:
TESTDONE: 1103 tests out of 1106 reported OK: 99%
TESTFAIL: These test cases failed: 1700 1701 1702
TESTDONE: 1374 tests were considered during 660 seconds.
bagder added a commit that referenced this issue Oct 13, 2020
@bagder
connect: repair build without ipv6 availability
153a0fb 
Reported-by: Tom G. Christensen
Fixes #6069
@bagder bagder mentioned this issue Oct 13, 2020
Closed
@bagder
Copy link
Member

bagder commented Oct 13, 2020

Can you give #6071 a try? I figure it should fix the build and make it work for you again.

@tgc
Copy link
Author

tgc commented Oct 14, 2020

I've tested the second patch posted by Jay, the one with AF_UNSPEC.
It seems to work fine, the build completes and the testresults are identical.

TESTDONE: 1103 tests out of 1106 reported OK: 99%
TESTFAIL: These test cases failed: 1700 1701 1702
TESTDONE: 1374 tests were considered during 671 seconds.

@tgc
Copy link
Author

tgc commented Oct 14, 2020

Result for 7.73.0 + patch:
OK (1375 out of 1375, remaining: 00:00, took 0.050s, duration: 11:20)
TESTDONE: 1130 tests out of 1130 reported OK: 100%
TESTDONE: 1387 tests were considered during 680 seconds.

jay added a commit that referenced this issue Oct 15, 2020
@jay
connect: repair build without ipv6 availability
f2828bb 
Assisted-by: Daniel Stenberg
Reported-by: Tom G. Christensen

Fixes #6069
Closes #6071
@bagder
Copy link
Member

bagder commented Oct 15, 2020

Thanks for verifying! Will merge this now...

@bagder bagder closed this as completed in 8b1a10c Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build connecting & proxies
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

connect: repair build without ipv6 availability curl/curl
2 participants
@bagder @tgc