cleanup: use Curl_ as prefix for internal global symbols
#5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As internal global names should use captical C.
As internal global names should use captical C.
As internal global names should use captical C.
Internal names should not be prefixed "curl_"
Use uppercase C for internal symbols.
bagder
force-pushed
the
bagder/uppercase-curl
branch
from
0e2f4e6
to
87bf895
Compare
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
As internal global names should use captical C. Closes #5906
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
As internal global names should use captical C. Closes #5906
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
Internal names should not be prefixed "curl_" Closes #5906
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
Use uppercase C for internal symbols. Closes #5906
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
bagder
added a commit
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a makeover to rename internally used structs that still were using
curl_prefix, despite our policy to only use that prefix for global symbols.One of the primary points with insisting on the distinction is to make it easier for developers to read the code and see when types/names are private or not.