Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select: simplify return code handling for poll and select #5880

Closed
wants to merge 1 commit into from
Closed

select: simplify return code handling for poll and select #5880

wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Aug 28, 2020

poll and select already return -1 on error according to POSIX,
so there is no need to perform a <0 to -1 conversion in code.

Also we can just use one check with <= 0 on the return code.

Assisted-by: Daniel Stenberg

Replaces #5852

@mback2k
select: simplify return code handling for poll and select
62e776f 
poll and select already return -1 on error according to POSIX,
so there is no need to perform a <0 to -1 conversion in code.

Also we can just use one check with <= 0 on the return code.

Assisted-by: Daniel Stenberg

Replaces curl#5852
@mback2k mback2k requested a review from bagder August 28, 2020 16:24
@mback2k mback2k self-assigned this Aug 28, 2020
@mback2k mback2k mentioned this pull request Aug 28, 2020
Closed
@mback2k mback2k closed this in 05729b6 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay approved these changes

@bagder bagder Awaiting requested review from bagder

Assignees

@mback2k mback2k

Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mback2k @jay