multi: handle connection state winsock events #5867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Learn from the way Cygwin handles and maps the WinSock events to simulate correct and complete poll and select behaviour according to Richard W. Stevens Network Programming book.
|
Looks reasonable to me, I'll take cygwin's word for it! |
jay
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Looks fine to me but I'd try for a clean CI. I tried to restart the failed azure jobs but apparently I don't have access to do that. Who is managing the azure instances? I assume the typical arbitrary unrelated failures, but please find out before landing this.
|
Thanks. Of course, I am always looking at the Windows CI (that I created). I think only Daniel and I currently can manage the Azure DevOps project, but you can use the following: /azp run windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MarcelRaad
approved these changes
Aug 27, 2020
mback2k
added a commit
to mback2k/curl
that referenced
this pull request
Aug 28, 2020
Learn from the way Cygwin handles and maps the WinSock events to simulate correct and complete poll and select behaviour according to Richard W. Stevens Network Programming book. Follow up to curl#5867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learn from the way Cygwin handles and maps the WinSock events
to simulate correct and complete poll and select behaviour
according to Richard W. Stevens Network Programming book.
Follow up to #5634
References to the corresponding mapping code in Cygwin:
https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/select.cc;h=9f1a8a57a07c9098bd497bc680b133310e1d2a35;hb=HEAD#l1631
https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/fhandler_socket_inet.cc;h=2b50671e533d70783cd1af00d8cc39e292e93ee8;hb=HEAD
cc @rcombs