Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor output with --verbose #5826

Closed
jmdavitt opened this issue Aug 17, 2020 · 3 comments
Closed

Poor output with --verbose #5826

jmdavitt opened this issue Aug 17, 2020 · 3 comments
Labels
TLS

Comments

@jmdavitt
Copy link

jmdavitt commented Aug 17, 2020 •
edited by bagder

I did this...

...while writing some code that receives, transforms, and runs curl requests.

curl -v -s -X GET -H ... 'https://api.XXXcom:443/sdxs/v1/director...'

I expected....

...verbose output (lines starting with *, >, <, {, &c.) before the content.
But the line detailing CApath started with spaces!

Here is sample output Mmarkdown turned asterisks to bullets):

* About to connect() to api.us-eaXXX.com port 443 (#4922 
*   Trying 34.202.246.104...
* Connected to api.us-eXXXcom (34.XXX104) port 443
* Initializing NSS with certpath: sql:/etc/pki/nssdb
* CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* SSL connection using TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate:

curl/libcurl version

curl 7.29.0 (x86_64-redhat-linux-gnu) libcurl/7.29.0 NSS/3.44
zlib/1.2.7 libidn/1.28 libssh2/1.8.0
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps
pop3 pop3s rtsp scp sftp smtp smtps telnet tftp
Features: AsynchDNS GSS-Negotiate IDN IPv6 Largefile NTLM NTLM_WB SSL
libz unix-sockets

operating system

Linux davitja.vzbi.com 3.10.0-1127.10.1.el7.x86_64 #1 SMP Wed Jun 3 14:28:03 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
@bagder
Copy link
Member

bagder commented Aug 17, 2020

Why is that poor? What did you expect instead? You're using an ancient curl version.

@jmdavitt
Copy link
Author

It's poor because the line should have started with an asterisk like all the accompanying output in that section.

Re "using an ancient curl version:" I agree... but I don't get to make those choices.

@bagder bagder added the TLS label Aug 17, 2020
@bagder
Copy link
Member

bagder commented Aug 17, 2020 •
edited

Aha, you speak of the CApath line. This output was introduced in curl in 1e98727, soon 17 years ago (update: uh maybe not, that commit was the OpenSSL line...). Yeah, I agree, it would be more consistent to have it start with an asterisk on that line...

bagder added a commit that referenced this issue Aug 17, 2020
@bagder
tls: provide the CApath verbose log on its own line
8aa5ba6 
... not newline separated from the previous line. This makes it output
asterisk prefixed properly like other verbose putput!

Reported-by: jmdavitt on github
Fixes #5826
@bagder bagder mentioned this issue Aug 17, 2020
Closed
@bagder bagder closed this as completed in 80d73bc Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tls: provide the CApath verbose log on its own line curl/curl
2 participants
@bagder @jmdavitt