Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Test requires default test server host and port" for any test run #5761

Closed
MarcelRaad opened this issue Aug 1, 2020 · 3 comments
Closed
Labels

Comments

@MarcelRaad
Copy link
Member

I did this

Look at any CI build. Alternatively, run the tests with runtests.pl.

I expected the following

Not to see this line in every single test suite run:

TESTINFO: "Test requires default test server host and port" 12 times (842, 843, 844, 845, 887, 888, 889, 890, 946 and 3 more)

Could it be that these tests cannot be run at all anymore since 80d6515?

Also, there are a lot of warnings

Use of uninitialized value $HTTPSPORT in substitution (s///) at /tests/runtests.pl line 3271."

as visible e.g. in https://curl.haxx.se/dev/log.cgi?id=20200801191819-7235#prob12, which seems to be caused by the same commit.

curl/libcurl version

7.72.0-DEV

operating system

Linux, macOS, Windows, FreeBSD, Solaris

@bagder bagder added the tests label Aug 1, 2020
@bagder
Copy link
Member

bagder commented Aug 1, 2020

Correct, tests that require "default host and port" can no longer run (unless by a fluke the random port happens to land on the single port the test can run on). They need to be adjusted to work on "any" port number.

@jay
Copy link
Member

jay commented Aug 2, 2020

=== Start of file http_server.log
21:03:54.633676 exit_signal_handler: 15
21:03:54.638788 signalled to die
21:03:54.639411 ========> IPv4 sws (port 55745 pid: 13877) exits with signal (15)
=== End of file http_server.log
=== Start of file https_stunnel.log
[ ] Clients allowed=125
[.] stunnel 5.50 on sparc-sun-solaris2.10 platform
[.] Compiled with OpenSSL 1.0.2o 27 Mar 2018
[.] Running with OpenSSL 1.0.2u 20 Dec 2019
[.] Threading:PTHREAD Sockets:POLL,IPv6 TLS:ENGINE,FIPS,OCSP,PSK,SNI Auth:LIBWRAP
[ ] errno: (*(___errno()))
[!] Invalid configuration file name "/build-17545/tests/https_stunnel.conf"
[!] realpath: Invalid argument (22)
[ ] Deallocating section defaults
=== End of file https_stunnel.log

@bagder
Copy link
Member

bagder commented Aug 2, 2020

@jay surely that's a separate problem?

bagder added a commit that referenced this issue Aug 4, 2020
This allows us to make test cases to use base64 at run-time and still
use and verify information determined at run-time, such as the IMAP test
server's port number in test 842.

ftpserver.pl is adjusted to load test instructions and test number from
the preprocessed test file.

FILEFORMAT.md now documents the new base64 encoding syntax.

Reported-by: Marcel Raad
Fixes #5761
@bagder bagder closed this as completed in 424092e Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants