Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nghttp2_strerror -> nghttp2_http2_strerror in debug messages #5641

Closed
wants to merge 1 commit into from
Closed

Fix nghttp2_strerror -> nghttp2_http2_strerror in debug messages #5641

wants to merge 1 commit into from

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Jul 2, 2020

Confusingly, nghttp2 has two different error code enums:

  • nghttp2_error, to be used with nghttp2_strerror
  • nghttp2_error_code, to be used with nghttp2_http2_strerror

@jbms
Fix nghttp2_strerror -> nghttp2_http2_strerror in debug messages
fae77d8 
Confusingly, nghttp2 has two different error code enums:

- nghttp2_error, to be used with nghttp2_strerror
- nghttp2_error_code, to be used with nghttp2_http2_strerror
@jbms jbms mentioned this pull request Jul 2, 2020
Closed
@bagder
Copy link
Member

bagder commented Jul 2, 2020

Thanks!

@bagder bagder closed this in 31f0e86 Jul 2, 2020
@jay jay added the HTTP/2 label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbms @bagder @jay