Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select: always use Sleep in Curl_wait_ms on Win32 #5489

Closed
wants to merge 1 commit into from
Closed

select: always use Sleep in Curl_wait_ms on Win32 #5489

wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented May 30, 2020

Since Win32 almost always will also have USE_WINSOCK,
we can reduce complexity and always use Sleep there.

Suggested-by: Jay Satiro

Follow up to #5343

@mback2k mback2k added Windows Windows-specific tidy-up labels May 30, 2020
@mback2k mback2k requested review from bagder and jay May 30, 2020 09:14
@mback2k mback2k self-assigned this May 30, 2020
jay
jay approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@jay jay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that ULONG_MAX < INFINITE check seems unnecessary you could just do it as ULONG_MAX -1/

@mback2k
select: always use Sleep in Curl_wait_ms on Win32
739adbc 
Since Win32 almost always will also have USE_WINSOCK,
we can reduce complexity and always use Sleep there.

Suggested-by: Jay Satiro
Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro

Follow up to curl#5343
Closes curl#5489
@mback2k
Copy link
Member Author

mback2k commented May 31, 2020

that ULONG_MAX < INFINITE check seems unnecessary you could just do it as ULONG_MAX -1/

Please take another look. I just updated this PR to work regardless of ULONG_MAX and INFINITE being equal or not. I think this one should be more robust now.

@mback2k mback2k requested review from jay and bagder May 31, 2020 18:35
jay
jay reviewed Jun 1, 2020
View reviewed changes
lib/select.c Show resolved Hide resolved
@mback2k mback2k closed this in 5325b92 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay approved these changes

@bagder bagder Awaiting requested review from bagder

Assignees

@mback2k mback2k

Labels
tidy-up Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mback2k @bagder @jay