Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: alloc the download buffer at transfer start #5472

Closed
wants to merge 1 commit into from
Closed

url: alloc the download buffer at transfer start #5472

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 28, 2020

It removes the extra alloc when a new size is set with setopt() and
reduces memory for unused easy handles.

@bagder bagder force-pushed the bagder/dlbuffer-on-demand branch 2 times, most recently from 75938f9 to 898d508 Compare May 29, 2020 11:47
@bagder
url: alloc the download buffer at transfer start
3e7eb97 
... and free it as soon as the transfer is done. It removes the extra
alloc when a new size is set with setopt() and reduces memory for unused
easy handles.

In addition: the closure_handle now doesn't use an allocated buffer at
all but the smallest supported size as a stack based one.

Closes #5472
@bagder bagder force-pushed the bagder/dlbuffer-on-demand branch from 0439a03 to 3e7eb97 Compare May 29, 2020 21:19
@bagder bagder closed this in c4e6968 May 30, 2020
@bagder bagder deleted the bagder/dlbuffer-on-demand branch May 30, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder