Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CURLOPT_PROXY_ISSUERCERT for consistency #5431

Closed
wants to merge 1 commit into from
Closed

add CURLOPT_PROXY_ISSUERCERT for consistency #5431

wants to merge 1 commit into from

Conversation

gvollant
Copy link
Contributor

CURLOPT_ISSUERCERT exists but not CURLOPT_PROXY_ISSUERCERT

the openssl vtls is already compatible with issuercert against proxy

jay
jay reviewed May 20, 2020
View reviewed changes
docs/libcurl/opts/Makefile.inc Outdated Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented May 20, 2020

This commit doesn't add any code that uses these options, is that already in place?

@gvollant
Copy link
Contributor Author

in openssl.c we have already

if(SSL_SET_OPTION(issuercert) || SSL_SET_OPTION(issuercert_blob)) {

and SSL_SET_OPTION will uses proxy parameters if needed

@bagder bagder closed this in 7f40633 May 23, 2020
@bagder
Copy link
Member

bagder commented May 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay left review comments

Assignees
No one assigned
Labels
libcurl API TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gvollant @bagder @jay