Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed uneeded decleration within for #5254

Closed
wants to merge 3 commits into from
Closed

Removed uneeded decleration within for #5254

wants to merge 3 commits into from

Conversation

Mipsters
Copy link
Contributor

fixed error: 'for' loop initial declaration used outside C99 mode
by declaring i in the beginning of the block instead of inside the for loop

gcc version 3.3.5 (Debian 1:3.3.5-13)

after fix and successful compilation, make test results:
https://pastebin.com/znEufH5H

@Mipsters
Removed uneeded decleration within for
3e5fc6e 
fixed error: 'for' loop initial declaration used outside C99 mode
by declaring i in the beginning of the block instead of inside the for loop

gcc version 3.3.5 (Debian 1:3.3.5-13)

after fix and successful compilation, `make test` results:
https://pastebin.com/znEufH5H
@danielgustafsson
Copy link
Member

There is another one in docs/examples/crawler.c which I think we should change too to keep us C89 across the tree. Care to include that one too in this patch?

@Mipsters
Copy link
Contributor Author

Done!
maybe the ci cd should include an old compiler test?
I noticed this because I work with a very old compiler, and it's best to catch these things early!
just a suggestion of course :)

@danielgustafsson
Copy link
Member

Thanks, looks good! There is a copyrightyear warning but don't worry about that one, I'll take care of that when pushing to master.

@danielgustafsson
Copy link
Member

Pushed with a tweak to the copyright year and some mild copyediting of the commit message. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgustafsson danielgustafsson danielgustafsson approved these changes

Assignees

@danielgustafsson danielgustafsson

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mipsters @danielgustafsson