Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: adapt to functions marked as deprecated since version 3 #5139

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 23, 2020

OpenSSL 3 deprecates SSL_CTX_load_verify_locations and the MD4, DES functions we use.

This commit fixes the MD4 and SSL_CTX_load_verify_locations warnings.

  • SSL_CTX_load_verify_locations
  • MD4
  • DES

The DES warnings are simply inhibited so far.

@bagder bagder added the TLS label Mar 23, 2020
@bagder bagder force-pushed the bagder/openssl3-deprecations branch from 94ca2db to 1b6ce8f Compare March 24, 2020 16:53
@bagder bagder marked this pull request as ready for review March 24, 2020 22:22
@bagder bagder changed the title [WIP] openssl: adapt to functions marked as deprecated since version 3 openssl: adapt to functions marked as deprecated since version 3 Mar 24, 2020
OpenSSL 3 deprecates SSL_CTX_load_verify_locations and the MD4, DES
functions we use.

Fix the MD4 and SSL_CTX_load_verify_locations warnings.

In configure, detect OpenSSL v3 and if so, inhibit deprecations
warnings. OpenSSL v3 deprecates the DES functions we use for NTLM and
until we rewrite the code to use non-deprecated functions we better
ignore these warnings as they don't help us.

Closes #5139
@bagder bagder force-pushed the bagder/openssl3-deprecations branch from 2630c9f to e4b7eaa Compare March 24, 2020 23:46
@bagder bagder closed this in 02174e4 Mar 25, 2020
@bagder bagder deleted the bagder/openssl3-deprecations branch March 25, 2020 23:41
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant