New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: remove python_dependencies for smbserver from our tree #5094
Conversation
This PR will only covers the removal of our in-tree Python dependencies. For Python 3 another PR will follow. |
FWIW, FreeBSD has impacket in ports as py37-impacket.
|
This comment has been minimized.
This comment has been minimized.
@bagder test 323 is now failing in this PR, because I made stunnel available to the CI builds. But I do not have any clue why it is failing, would you mind taking a look at the failed Azure jobs? |
5453237
to
c44bc7d
Compare
@dfandrich for now I added |
c44bc7d
to
86f6c73
Compare
I don't see any azure jobs at all? |
@bagder that is what I meant with "something is wrong with Azure CI not triggering for PRs anymore". After doing a force-push they weren't triggering anymore for some unknown reason. |
84e6f9e
to
8ac64cd
Compare
This comment has been minimized.
This comment has been minimized.
Azure CI builds are for unknown reasons missing for this PR, but are looking good on my end. |
Users of the SMB tests will have to install impacket manually. Reasoning: our in-tree version of impacket was quite outdated and only compatible with Python 2 which is already end-of-life. Upgrading to Python 3 and a compatible impacket version would require to import additional Python-only and CPython-extension dependencies. This would have hindered portability enormously.
5e56138
to
79aa91e
Compare
79aa91e
to
c5095fb
Compare
@dfandrich I will just add impacket to the FreeBSD builds in another PR to have this finished. |
Pending topics for follow up PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also AppVeyor would be a candidate to install impacket later. We currently don't install any additional software there, but test 1451 is currently run and passing.
@MarcelRaad good idea, I guess it will make sense to include it in the WSL-based builds I am creating. For the other builds I am not sure how to install something in the Git bash.exe environment. |
Users of the SMB tests will have to install impacket manually.
Reasoning: our in-tree version of impacket was quite outdated
and only compatible with Python 2 which is already end-of-life.
Upgrading to Python 3 and a compatible impacket version would
require to import additional Python-only and CPython-extension
dependencies. This would have hindered portability enormously.
See also #5085 for the previous discussion leading into this PR.