Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: now require nghttp2 >= 1.12.0 #4961

Closed
wants to merge 1 commit into from
Closed

http2: now require nghttp2 >= 1.12.0 #4961

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 21, 2020

To simplify our code and since earlier versions lack important function
calls libcurl needs to function correctly.

nghttp2 1.12.0 was relased on June 26, 2016.

@bagder
http2: now require nghttp2 >= 1.12.0
000880e 
To simplify our code and since earlier versions lack important function
calls libcurl needs to function correctly.

nghttp2 1.12.0 was relased on June 26, 2016.
@bagder bagder closed this in 5808a0d Feb 21, 2020
@bagder bagder deleted the bagder/nghttp2-requirement branch February 21, 2020 15:55
@Biswa96
Copy link
Contributor

Biswa96 commented Apr 8, 2023

Apology for this late question. The http2_strerror function was removed in this commit. But the Curl_http2_strerror declaration is still present in lib/http2.h. Is that expected? See the line here

curl/lib/http2.h

Line 41 in 712e5f1

const char *Curl_http2_strerror(uint32_t err);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @Biswa96