Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sha256: Added TLS library based implementations #4956

Closed
wants to merge 6 commits into from
Closed

sha256: Added TLS library based implementations #4956

wants to merge 6 commits into from

Conversation

captain-caveman2k
Copy link
Contributor

@captain-caveman2k captain-caveman2k commented Feb 20, 2020 •
edited

Implemented SHA256 support through the following TLS libraries rather than limiting to either OpenSSL or our own native implementation:

  • GNU TLS Nettle
  • GNU TLS gcrypt
  • mbed TLS

nickzman
nickzman reviewed Feb 20, 2020
View reviewed changes
lib/sha256.c Outdated Show resolved Hide resolved
bagder
bagder reviewed Feb 20, 2020
View reviewed changes
lib/sha256.c Show resolved Hide resolved
@captain-caveman2k captain-caveman2k mentioned this pull request Feb 20, 2020
Closed
@captain-caveman2k captain-caveman2k mentioned this pull request Feb 25, 2020
Closed
@captain-caveman2k captain-caveman2k mentioned this pull request Feb 26, 2020
Closed
@bagder
Copy link
Member

bagder commented Mar 3, 2020

This PR merge introduced test 1610 failures on macos without TLS:

https://dev.azure.com/daniel0244/curl/_build/results?buildId=902&view=logs&j=12352f4a-0d11-5197-0393-8a084f220de5&t=b606a952-a560-5f0c-07fb-88af8a444425&l=2903

We're < 24 hours from release. This needs to be fixed ASAP.

@bagder bagder reopened this Mar 3, 2020
bagder added a commit that referenced this pull request Mar 3, 2020
@bagder
Revert "sha256: Added SecureTransport implementation"
11a7779 
This reverts commit 4feb38d (from #4956)

That commit broke test 1610 on macos builds without TLS.
@bagder bagder mentioned this pull request Mar 3, 2020
Closed
@bagder
Copy link
Member

bagder commented Mar 3, 2020

we handle the single reverted commit in #5027, as it seems to be enough to get back to green macos builds

@bagder bagder closed this Mar 3, 2020
bagder added a commit that referenced this pull request Mar 3, 2020
@bagder
Revert "sha256: Added SecureTransport implementation"
b572e0b 
This reverts commit 4feb38d (from #4956)

That commit broke test 1610 on macos builds without TLS.

Closes #5027
@captain-caveman2k captain-caveman2k mentioned this pull request Mar 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickzman nickzman nickzman left review comments

@bagder bagder bagder left review comments

@jay jay jay left review comments

Assignees
No one assigned
Labels
cryptography
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@captain-caveman2k @bagder @nickzman @jay